Skip to content

PHPLIB-1725 Add Session::getSnapshotTime in spec tests #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GromNaN wants to merge 1 commit into
base: v2.x
Choose a base branch
from
Draft

PHPLIB-1725 Add Session::getSnapshotTime in spec tests #1799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/UnifiedSpecTests/Operation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,9 @@ private function executeForSession(Session $session)
case 'endSession':
return $session->endSession();

case 'getSnapshotTime':
throw new \RuntimeException('TODO: Implement getSnapshotTime');
Copy link
Member

@jmikola jmikola Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to add test skips to this PR? Or is it really waiting on PHPLIB-1725 to implemented? I think we're going to need a PHPC ticket between that and CDRIVER-6098 to track the MongoDB\Driver\Session API changes.

I found this property documented in ClientSession Changes in the Snapshot Sessions spec. The change dates back to mongodb/specifications@03795d2 and DRIVERS-2782, although the JIRA title doesn't mention this field.

Copy link
Member

@alcaeus alcaeus Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've followed up as DRIVERS-2782 is still in review, meaning that the downstream tickets are still blocked. That said, I've cloned PHPLIB-1725 to PHPC-2658 as we have to expose this as a new method in the MongoDB\Driver\Session class first.


case 'startTransaction':
return $session->startTransaction($args);

Expand Down
1 change: 1 addition & 0 deletions tests/UnifiedSpecTests/Util.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ final class Util
'abortTransaction' => [],
'commitTransaction' => [],
'endSession' => [],
'getSnapshotTime' => [],
'startTransaction' => ['maxCommitTimeMS', 'readConcern', 'readPreference', 'writeConcern'],
'withTransaction' => ['callback', 'maxCommitTimeMS', 'readConcern', 'readPreference', 'writeConcern'],
],
Expand Down
2 changes: 1 addition & 1 deletion tests/specifications
Open in desktop
Submodule specifications updated 41 files
+3 −1 source/auth/auth.md
+24 −24 source/compression/OP_COMPRESSED.md
+0 −3 source/open-telemetry/tests/operation/aggregate.json
+1 −1 source/open-telemetry/tests/operation/aggregate.yml
+85 −7 source/open-telemetry/tests/operation/atlas_search.json
+34 −3 source/open-telemetry/tests/operation/atlas_search.yml
+0 −3 source/open-telemetry/tests/operation/bulk_write.json
+0 −1 source/open-telemetry/tests/operation/bulk_write.yml
+29 −0 source/open-telemetry/tests/operation/delete.json
+11 −0 source/open-telemetry/tests/operation/delete.yml
+5 −0 source/open-telemetry/tests/operation/drop_collection.json
+5 −0 source/open-telemetry/tests/operation/drop_collection.yml
+0 −15 source/open-telemetry/tests/operation/find.json
+0 −5 source/open-telemetry/tests/operation/find.yml
+11 −6 source/open-telemetry/tests/operation/find_and_modify.json
+9 −6 source/open-telemetry/tests/operation/find_and_modify.yml
+11 −5 source/open-telemetry/tests/operation/find_without_query_text.json
+4 −2 source/open-telemetry/tests/operation/find_without_query_text.yml
+32 −3 source/open-telemetry/tests/operation/insert.json
+13 −2 source/open-telemetry/tests/operation/insert.yml
+8 −6 source/open-telemetry/tests/operation/list_collections.json
+3 −2 source/open-telemetry/tests/operation/list_collections.yml
+4 −1 source/open-telemetry/tests/operation/list_databases.json
+2 −0 source/open-telemetry/tests/operation/list_databases.yml
+0 −3 source/open-telemetry/tests/operation/list_indexes.json
+1 −1 source/open-telemetry/tests/operation/list_indexes.yml
+0 −3 source/open-telemetry/tests/operation/map_reduce.json
+1 −1 source/open-telemetry/tests/operation/map_reduce.yml
+12 −15 source/open-telemetry/tests/operation/retries.json
+10 −10 source/open-telemetry/tests/operation/retries.yml
+33 −1 source/open-telemetry/tests/operation/update.json
+14 −1 source/open-telemetry/tests/operation/update.yml
+96 −7 source/open-telemetry/tests/transaction/convenient.json
+39 −4 source/open-telemetry/tests/transaction/convenient.yml
+176 −11 source/open-telemetry/tests/transaction/core_api.json
+67 −6 source/open-telemetry/tests/transaction/core_api.yml
+43 −13 source/sessions/snapshot-sessions.md
+25 −0 source/sessions/tests/README.md
+804 −0 source/sessions/tests/snapshot-sessions.json
+404 −1 source/sessions/tests/snapshot-sessions.yml
+10 −0 source/unified-test-format/unified-test-format.md