-
Notifications
You must be signed in to change notification settings - Fork 246
chore(components): upgrade LeafyGreen chat components COMPASS-9642 #7610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e822695 to
a8bf853
Compare
deff4e5 to
274efbb
Compare
b1fc553 to
c20fba8
Compare
c20fba8 to
7438147
Compare
944ee4d to
2ba18e7
Compare
2ba18e7 to
c6ecdb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades LeafyGreen chat and assistant-related UI component packages to their latest versions. The changes primarily involve package version bumps and the removal of custom CSS workarounds that are no longer needed with the updated LeafyGreen components.
- Upgraded chat-related LeafyGreen packages (@lg-chat/*) to major versions
- Updated LeafyGreen tokens and select components to latest versions
- Removed custom CSS styling overrides that are now handled by the upgraded components
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/compass-components/package.json | Updates LeafyGreen chat components and tokens to latest versions |
| packages/compass-assistant/src/components/assistant-chat.tsx | Removes custom CSS workarounds for layout, padding, and styling that are now handled by upgraded components |
| packages/compass-assistant/src/components/assistant-chat.spec.tsx | Updates test expectation to match new disclaimer text from upgraded components |
| packages/compass-assistant/src/compass-assistant-provider.spec.tsx | Fixes test setup to properly resolve promises with closed ReadableStreams |
| package.json | Updates root-level LeafyGreen package versions to match |
| "@lg-chat/message": "^10.1.1", | ||
| "@mongodb-js/compass-context-menu": "^0.3.2", | ||
| "@mongodb-js/diagramming": "^2.2.2", | ||
| "@mongodb-js/diagramming": "2.2.2", |
Copilot
AI
Dec 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version specifier for @mongodb-js/diagramming was changed from '^2.2.2' to '2.2.2' (exact version). This differs from all other dependencies which use caret (^) ranges. Unless there's a specific reason to pin this exact version, it should use '^2.2.2' for consistency with the rest of the package.json.
| "@mongodb-js/diagramming": "2.2.2", | |
| "@mongodb-js/diagramming": "^2.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a workaround until #7643 lands.
| > | ||
| <LeafyGreenChatProvider> | ||
| <ChatWindow title="MongoDB Assistant" className={chatWindowFixesStyles}> | ||
| <ChatWindow> |
Copilot
AI
Dec 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title prop 'MongoDB Assistant' was removed from ChatWindow. If the title is still needed for accessibility or UI purposes, consider documenting why it was removed or verify that the upgraded component handles this internally.
| <ChatWindow> | |
| <ChatWindow aria-label="MongoDB Assistant"> |
COMPASS-9642
Description
Stacked on #7594.
This PR upgrades the chat / assistant related LG packages to their latests version.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes