Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
d9894b2
Upgrade LG modal packages
kraenhansen Dec 18, 2025
8096983
Fix Modal to adopt LG Modal v20
kraenhansen Sep 30, 2025
1a79dee
Fix connection-form to work around LG Modal v20
kraenhansen Sep 30, 2025
baf002b
Update generative-ai to adopt marketing-modal v7
kraenhansen Sep 30, 2025
9fc6af6
Fix compass-import-export to work around LG modal v20
kraenhansen Sep 30, 2025
e1855b4
Update compass-welcome to adopt marketing-modal v7
kraenhansen Nov 5, 2025
c5274cb
Update compass-explain-plan to LG Modal v20
kraenhansen Oct 1, 2025
37a6cc7
Fix compass-crud to adopt LG modal v20
kraenhansen Oct 1, 2025
5f418d2
Update compass-schema to LG Modal v20
kraenhansen Oct 1, 2025
65831d9
Add workaround for jsdom missing HTMLDialogElement support
kraenhansen Oct 2, 2025
09eb31d
Update generative-ai to adopt LG modal v20
kraenhansen Oct 7, 2025
cd281f6
Fix fullScreen prop on derived Modal
kraenhansen Oct 7, 2025
21f3682
Remove use of deprecated backdropClassName
kraenhansen Oct 7, 2025
aa0f76f
Remove workaround for MarketingModal button disabling
kraenhansen Dec 10, 2025
5cc4946
Fix remaining components tests
kraenhansen Oct 7, 2025
5ae783d
Revert workaround for LG-5593
kraenhansen Oct 8, 2025
669e0cd
Update existing tests to handle dialog elements remaining in the DOM
kraenhansen Nov 5, 2025
e473a04
Update databases-collections to allow immediate removal of the heading
kraenhansen Nov 6, 2025
01c66a3
Update e2e tests to use waitForDisplayed over waitForExist as this is…
kraenhansen Nov 6, 2025
b343940
Update e2e tests removing [role=dialog] from confirm dialog selectors
kraenhansen Nov 7, 2025
3cdb6c7
Update e2e tests to wait for bulk delete modal to disappear
kraenhansen Nov 7, 2025
ad72a99
Update e2e tests to wait for connection form to be non-clickable in a…
kraenhansen Nov 7, 2025
5e5ce3b
Update e2e tests to fix modal regressions
kraenhansen Nov 21, 2025
2778a71
Disable pointer events on a closed modal
kraenhansen Nov 10, 2025
d1fe84b
Disable auto-focus on confirmation modal children by default
kraenhansen Nov 10, 2025
6ab317e
Add new modal specific commands
kraenhansen Nov 11, 2025
70e7015
Update E2E tests to use new modal commands instead of waitForDisplayed
kraenhansen Nov 11, 2025
f839793
Default initialFocus to "null" to avoid breaking existing modals
kraenhansen Nov 12, 2025
cf032a1
Wait for confirm button to show instead of simply expecting it
kraenhansen Nov 17, 2025
bb6ff36
Update FocusMode tests to handle LG Modal v20
kraenhansen Nov 25, 2025
3799746
Update SettingsModal tests to handle LG Modal v20
kraenhansen Nov 25, 2025
7ca774e
Clarify disabling the @typescript-eslint/no-namespace and add a TODO …
kraenhansen Nov 26, 2025
de78fec
Partial revert of ddd6d70dd59fbe8f948ea6e5ef80b6d478bc1eff
kraenhansen Nov 26, 2025
920efc6
Fix auto-focus in bulk update and delete modals
kraenhansen Dec 1, 2025
2f73260
Correcting sizing styles
kraenhansen Dec 9, 2025
c2e5d46
Correcting sizing styles more
kraenhansen Dec 9, 2025
9646d87
Use named imports
kraenhansen Dec 18, 2025
d43fc16
Upgrade confirm-modal package
kraenhansen Dec 18, 2025
dbe7574
Fix useConfirmation's confirmButtonProps types
kraenhansen Dec 18, 2025
9767e4f
Update use of ConfirmationModal
kraenhansen Dec 18, 2025
564fc1e
Set initial focus on cancel (fallback to confirm) button
kraenhansen Dec 18, 2025
6fa377d
Fix package lock
kraenhansen Dec 18, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,25 @@ Object.assign(tabbable, {
origTabbable.isTabbable(node, { ...options, displayCheck: 'none' }),
});

// Workaround for missing HTMLDialogElement in jsdom
// See https://github.com/jsdom/jsdom/issues/3294

Object.assign(HTMLDialogElement.prototype, {
show() {
this.open = true;
this.style.display = '';
},
showModal() {
this.open = true;
this.style.display = '';
},
close(returnValue) {
this.open = false;
this.returnValue = returnValue;
this.style.display = 'none';
},
});

// leafygreen (through `clipboard` library) uses deprecated API check that is
// not working in jsdom if copy / paste APIs are supported
if (!window.document.queryCommandSupported) {
Expand Down
43 changes: 43 additions & 0 deletions configs/testing-library-compass/src/assertions.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import { Assertion, util } from 'chai';

// TODO(COMPASS-10119): Move declaration into a separate .d.ts and implementation into a *-register.js file as we do with other global patching code intended for tests.

declare global {
// eslint-disable-next-line @typescript-eslint/no-namespace -- We're following a pattern established in the `@types/chai-as-promised` package to add a Chai assertion property.
export namespace Chai {
interface Assertion {
/** Asserts that a dialog is open */
get open(): Assertion;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anemy FYI for the eslint plugin you are working on in devtools-shared, new terminator assertion

/** Asserts that a dialog is closed */
get closed(): Assertion;
}
}
}

util.addProperty(
Assertion.prototype,
'open',
function (this: typeof Assertion) {
const obj = util.flag(this, 'object');
new Assertion(obj).to.be.instanceof(HTMLDialogElement);
new Assertion(obj as HTMLDialogElement).has.property(
'open',
true,
'Expected dialog to be open'
);
}
);

util.addProperty(
Assertion.prototype,
'closed',
function (this: typeof Assertion) {
const obj = util.flag(this, 'object');
new Assertion(obj).to.be.instanceof(HTMLDialogElement);
new Assertion(obj as HTMLDialogElement).has.property(
'open',
false,
'Expected dialog to be closed'
);
}
);
2 changes: 2 additions & 0 deletions configs/testing-library-compass/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ import { expect } from 'chai';
import { Provider } from 'react-redux';
import ConnectionString from 'mongodb-connection-string-url';

import './assertions';

function wait(ms: number) {
return new Promise((resolve) => {
setTimeout(resolve, ms);
Expand Down
Loading
Loading