Skip to content

Conversation

@lewisdaly
Copy link
Contributor

@lewisdaly lewisdaly commented Mar 26, 2021

part of mojaloop/project#2100

Additionally:

  • adds unit tests and basic coverage
  • update circleci to v2.1

BREAKING CHANGE: I removed what looks like redundant schemas and models, but since they could potentially still be accessed by a client library, I consider this a breaking change

@lewisdaly lewisdaly changed the title feat: #2100 allow config options to be passed through to Mongoose feat!: #2100 allow config options to be passed through to Mongoose Mar 26, 2021
@elnyry-sam-k elnyry-sam-k requested a review from vgenev March 26, 2021 07:59
@lewisdaly lewisdaly requested a review from mdebarros March 31, 2021 00:14
@lewisdaly lewisdaly marked this pull request as ready for review March 31, 2021 00:14
@lewisdaly
Copy link
Contributor Author

I've validated this on central-ledger with some integration tests.

@lewisdaly
Copy link
Contributor Author

@elnyry-sam-k who is the best person to review this?

@elnyry-sam-k
Copy link
Member

@vgenev , @mdebarros can you please help with this

@lewisdaly
Copy link
Contributor Author

Bump @vgenev @mdebarros

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants