Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RedisCommandReplicator Native method implementation #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-pr
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
RedisCommandReplicator Native method implementation #3
Changes from all commits
afec9478fec6913222193ca4a1f885d3256fd6d8d716b7b286ce07bb07c3f4c16ad65952891e576929c789b81edc8fa4e0b9ad5bf1f940eeec8205b563db9bf4ed19c4b0db5ef24a3a0431b3ffd5a67e7757f24b29762dcc08af0734f05b43719ab49da4aef2457897d99bdc9c5b568297fcf6216074b2File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 65 in microsphere-redis-replicator-spring/src/main/java/io/microsphere/redis/replicator/spring/RedisCommandReplicator.java
This block of commented-out lines of code should be removed.
Check warning on line 6 in microsphere-redis-replicator-spring/src/main/java/io/microsphere/redis/replicator/spring/event/handler/RedisCommandReplicatedEventHandler.java
Replace generic exceptions with specific library exceptions or a custom exception.
Check warning on line 85 in microsphere-redis-replicator-spring/src/test/java/io/microsphere/redis/benchmark/RedisCommandReplicatedEventHandlerBenchmark.java
Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body.
Uh oh!
There was an error while loading. Please reload this page.