added loopbackDSR support for all IPAMs #125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschott
force-pushed
the
user/daschott/loopbackdsr-fix
branch
from
9bd54cf to
a10e195
Compare
| logrus.Errorf("[cni-net] Failed to create endpoint, error : %v.", err) | ||
| return err | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Good to have a success log (info) after the successful endpoint creation.
| if err != nil { | ||
| return fmt.Errorf("failed to apply policy to endpoint: %v", err) | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Good to have a success log (info) after the policy is applied successfully.
princepereira
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for loopbackDSR policy for all IPAM modes
Previously, loopbackDSR would fail to be added when HNS was used as IPAM. This is because the IP address was not available until after the endpoint was created. In contrast, using host-local as IPAM would ensure the IP address was in the epInfo beforehand. Now I added logic to check if the IP address exists. If it doesn't exist, we will add the loopbackDSR policy after endpoint creation. Without this fix, CNI would fail to create the endpoint if loopbackDSR is enabled and HNS is used as the IPAM.