Fix paths when running in a codespace or github.dev browser extension #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR injects path substitutions to correctly convert file paths in the debugger to those used in VS Code in some web scenarios.
This fixes #89, however this wasn't necessary in the past and it's possible this is working around a recent regression in VS Code and should be fixed there.
If not, it may be better to implement this fix in the underlying DebugSession conversion functions, however this would require knowledge of the current UI file scheme injected from the client somehow.
To recreate the issue, please refer to instructions on the test repo here:
https://github.com/thegecko/vscode-web-test
To help with testing, a duplicate version of the mock-debug extension including these fixes is published here:
https://marketplace.visualstudio.com/items?itemName=arm-debug.mock-debug-test
Tested to be working on: