Refactoring building and deployment of Docker services #60
Conversation
andrsuh
left a comment
andrsuh
left a comment
There was a problem hiding this comment.
Thank you! Please respond to my comments and questions.
| client: | ||
| serviceUrl: | ||
| defaultZone: http://localhost:8761/eureka/ | ||
| defaultZone: http://eureka:8761/eureka/ |
There was a problem hiding this comment.
application.yml is used for local deployment. We can override this property in application-docker.yml and then if application is run with flag --spring.active.profiles=docker the proper property from application-docker.yml will be applied
There was a problem hiding this comment.
Did you have a chance to take a look at this?
| @@ -1,6 +1,8 @@ | |||
| .gradle | |||
There was a problem hiding this comment.
If running gradle from top, this directory is created. Also, I think this will ignore .gradle in each sub-directory also, which is good, since it is a technical directory and mainly mustn't be committed.
| archiveBaseName = "accounting-api" | ||
| } | ||
|
|
||
| repositories { |
There was a problem hiding this comment.
Because repositories are declared once in top of multi-module project. Instead of duplicating things in each sub-project separately. And handled by Artifactory to abuse caching as much as possible.
| } | ||
| } | ||
| } | ||
| apply plugin: "java" |
There was a problem hiding this comment.
please move plugin declaration at the top of scope
| @@ -1,4 +1,4 @@ | |||
| FROM grafana/grafana | |||
| FROM grafana/grafana:6.3.6 | |||
There was a problem hiding this comment.
Did you make sure that all stays working after this changes?
There was a problem hiding this comment.
No but made sure this is the version with ubuntu in it. The new latest image(which is default) now based on Apline and since I ain't sure of purpose of this change, I kept it all as is.
There was a problem hiding this comment.
I think the original author can fix it if necessary.
There was a problem hiding this comment.
But it is a bad practice not to set the version if you're inherit from another image.
2 participants
local MavenwithArtifactoryArtifactoryArtifactoryArtifactoryDockerfiles