Fix memory leaks upon disconnect #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Options --with-libxml2 and --without-libxml2 are broken. libstrophe is always built with libxml2 support. This patch fixes the problem and makes libstrophe be built with expat support by default.
zero-length buffer will cause problem within 'base64_decoded_len' and with use of uninitialized 'hextet'
size_t is unsigned type. We should declare len as either ssize_t or int
Also fixed possible null pointer dereference in _add_key.
implement list_init implement list_init_item implement list_pull_first implement list_insert implememt list_append
rename list_pull_first rename list_pull_next rename list_pull_last rename list_append
implement list_get_first implement list_get_next implement list_pop_by_data
Addition of ping namespace
(1) the connection did not release its sendqueue in
xmpp_conn_release.
(2) the connection did not release its TLS context in
xmpp_conn_release.
Conflicts: src/conn.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
First, thanks for libstrophe. I was in the need for a sleek C XMPP library and it comes in really handy. Please merge the two memleak fixes I attached, so that my router won't crash after a few days :).
(1) the connection did not release its sendqueue in xmpp_conn_release.
(2) the connection did not release its TLS context in xmpp_conn_release.
regards,
Jonas