xmpp_graceful_stop(ctx,timeout) + fix for send_queue_len #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was incremented, but not decremented. I've corrected the code to decrement it. It doesn't appear to be used anywhere, but it is helpful to implement xmpp_graceful_stop().
xmpp_graceful_stop() waits until timeout for existing enqueued data to be sent. This helps write applications with libstrope that wish to verify the data the enqueued made it to the network before the run loop exited.
Add declaration missing from strophe.h for xmpp_graceful_stop().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xmpp_graceful_stop(ctx,timeout) waits until either all connections have a send_queue_len of zero or timeout elapses. The primary motivation is to have an easy way to signal shutdown after any enqueued messages have been sent. The previous commit, adds a one line fix to decrement send_queue_len so it contains the length of the queue.
This works for my simple program, let me know if this looks correct to you.
Garick