Skip to content

Fix oss build #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zdevito wants to merge 1 commit into
base: gh/zdevito/152/base
Choose a base branch
from
+2 −3
Open

Fix oss build #2203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions python/tests/test_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,11 +395,10 @@ def test_train_script_job_state_batch():
try:
job = LocalJob(("batch_launched_hosts",))
job.apply(client_script=train_script)
status = job.process.wait()
stdout = open(os.path.join(job._log_dir, "stdout.log"), "r").read()
stderr = open(os.path.join(job._log_dir, "stderr.log"), "r").read()
assert (
0 == job.process.wait()
), f"Job failed\nstdout:\n{stdout}\nstderr:\n{stderr}"
assert status == 0, f"Job failed\nstdout:\n{stdout}\nstderr:\n{stderr}"
assert "batch_launched_hosts True" in stdout
# look in job._log_dir for the stdout file which will have the batch_lauched_hosts True
finally:
Expand Down
Loading