Fix a race in tensor engine #2200
Open
+29
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for an actor message to try to lookup a broker actor before the mesh controller has actually launched it. I started to see flaky tests from this recently. This is a workaround to stop the tests from being flaky because we know that the broker was spawned and we just have to wait for it to come into existence. The better solution, which requires much more refactoring, is to have the controller to spawn brokers and pass them as an argument to the controller so that it also has the broker references. Differential Revision: [D89690423](https://our.internmc.facebook.com/intern/diff/D89690423/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D89690423/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Dec 22, 2025
It is possible for an actor message to try to lookup a broker actor before the mesh controller has actually launched it. I started to see flaky tests from this recently. This is a workaround to stop the tests from being flaky because we know that the broker was spawned and we just have to wait for it to come into existence. The better solution, which requires much more refactoring, is to have the controller to spawn brokers and pass them as an argument to the controller so that it also has the broker references. Differential Revision: [D89690423](https://our.internmc.facebook.com/intern/diff/D89690423/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D89690423/)! ghstack-source-id: 330887231 Pull Request resolved: #2200
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
It is possible for an actor message to try to lookup a broker actor before the mesh controller has actually launched it. I started to see flaky tests from this recently. This is a workaround to stop the tests from being flaky because we know that the broker was spawned and we just have to wait for it to come into existence. The better solution, which requires much more refactoring, is to have the controller to spawn brokers and pass them as an argument to the controller so that it also has the broker references.
Differential Revision: D89690423
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!