Proper flushing on shutdown #2197
Open
+137
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We were previously relying on `Drop` in some places to invoke flushing but this will not work reliably from Python. What we should do instead is invoke a shutdown function in `shutdown_tokio_runtime` Differential Revision: D89674332
meta-cla
bot
added
the
CLA Signed
|
@thomasywang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89674332. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We were previously relying on
Dropin some places to invoke flushing but this will not work reliably from Python. What we should do instead is invoke a shutdown function inshutdown_tokio_runtimeDifferential Revision: D89674332