: regualar rlib, not a python extension module #2152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89247451. |
Summary: convert `monarch_hyperactor` from `rust_python_library` to `rust_library` and add `extension-module` to `monarch_extension` `monarch_hyperactor` is not a Python extension module - it has no `#[pymodule]` entry point. the actual Python extension is `monarch_extension`, which depends on `monarch_hyperactor` and exposes its types to Python. this change converts `monarch_hyperactor` from `rust_python_library` to `rust_library`, removing the `dependencies_override`. it adds the `extension-module` feature to pyo3 in `monarch_extension` where it belongs, removes a non-functional `#[pymodule]` attribute from `monarch_hyperactor/src/channel.rs`, and removes incorrect dependencies from Python type stubs that were depending on `monarch_hyperactor` instead of `monarch_extension`. Differential Revision: D89247451
shayne-fletcher
force-pushed
the
export-D89247451
branch
from
a386ecd to
81f56a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D89247451