Add links to model description #125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
There was a problem hiding this comment.
Pull request overview
This PR enhances the documentation by adding hyperlinks to the model descriptions in the Android LlamaDemo README, making it easier for users to navigate to detailed model-specific documentation.
- Adds GitHub repository links to each supported model type
- Organizes Llama model variants under a nested list structure
- Maintains the same model information while improving discoverability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * Llama 2 7B | ||
| * [LLaVA-1.5 vision model (only XNNPACK)](https://github.com/pytorch/executorch/tree/main/examples/models/llava) | ||
| * [Qwen 3 0.6B, 1.7B, and 4B](https://github.com/pytorch/executorch/tree/main/examples/models/qwen3) | ||
| * [Voxtral Mini 3B](https://github.com/pytorch/executorch/blob/main/examples/models/voxtral) |
There was a problem hiding this comment.
The URL path uses /blob/main/ while all other model links use /tree/main/. For consistency with the other links and because this appears to be a directory (not a single file), this should use /tree/main/ instead of /blob/main/.
Suggested change
| * [Voxtral Mini 3B](https://github.com/pytorch/executorch/blob/main/examples/models/voxtral) | |
| * [Voxtral Mini 3B](https://github.com/pytorch/executorch/tree/main/examples/models/voxtral) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.