Drop doctrine annotations #424
Conversation
WalkthroughMigrated Doctrine ORM and Symfony Serializer metadata from PHPDoc docblocks to PHP 8 attributes across test entities; updated serializer import paths for Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (16)
💤 Files with no reviewable changes (11)
🚧 Files skipped from review as they are similar to previous changes (4)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-12-15T19:07:07.476ZApplied to files:
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
=======================================
Coverage 72.38% 72.38%
=======================================
Files 28 28
Lines 1224 1224
=======================================
Hits 886 886
Misses 338 338 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
tests/Entity/Post.php (2)
62-63: Incomplete migration: Replace docblock annotation with attribute.The
@Groupsannotation in the docblock should be replaced with the PHP 8 attribute to complete the migration.Apply this diff:
- /** - * @Groups({"searchable"}) - */ + #[Groups('searchable')] public function getTitle(): ?string
75-76: Incomplete migration: Replace docblock annotation with attribute.The
@Groupsannotation in the docblock should be replaced with the PHP 8 attribute to complete the migration.Apply this diff:
- /** - * @Groups({"searchable"}) - */ + #[Groups('searchable')] public function getPublishedAt(): \DateTimeImmutable
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (16)
.gitignore(1 hunks)tests/Entity/Article.php(0 hunks)tests/Entity/Car.php(0 hunks)tests/Entity/Comment.php(1 hunks)tests/Entity/ContentAggregator.php(0 hunks)tests/Entity/ContentItem.php(0 hunks)tests/Entity/DummyCustomGroups.php(1 hunks)tests/Entity/DynamicSettings.php(0 hunks)tests/Entity/EmptyAggregator.php(0 hunks)tests/Entity/Image.php(0 hunks)tests/Entity/Link.php(0 hunks)tests/Entity/Page.php(1 hunks)tests/Entity/Podcast.php(0 hunks)tests/Entity/Post.php(1 hunks)tests/Entity/SelfNormalizable.php(0 hunks)tests/Entity/Tag.php(0 hunks)
💤 Files with no reviewable changes (11)
- tests/Entity/Podcast.php
- tests/Entity/Car.php
- tests/Entity/ContentAggregator.php
- tests/Entity/SelfNormalizable.php
- tests/Entity/Article.php
- tests/Entity/ContentItem.php
- tests/Entity/Tag.php
- tests/Entity/Link.php
- tests/Entity/EmptyAggregator.php
- tests/Entity/DynamicSettings.php
- tests/Entity/Image.php
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-15T19:07:07.476Z
Learnt from: norkunas
Repo: meilisearch/meilisearch-symfony PR: 410
File: src/Identifier/DefaultIdNormalizer.php:18-22
Timestamp: 2025-12-15T19:07:07.476Z
Learning: In PHP projects (Symfony style), avoid importing global PHP classes (e.g., \InvalidArgumentException, \LogicException) via use statements inside namespaces. Instead, reference them with a leading backslash (fully qualified name) when used, e.g. \InvalidArgumentException $e = new \InvalidArgumentException('msg'); This preserves clarity about the global namespace and follows Symfony coding conventions for global classes.
Applied to files:
tests/Entity/Page.phptests/Entity/DummyCustomGroups.phptests/Entity/Post.phptests/Entity/Comment.php
🔇 Additional comments (5)
.gitignore (1)
7-7: Good housekeeping—ignoring generated/temporary reference file.The addition of
/config/reference.phpto.gitignorefollows Git conventions and is logically placed within the configuration section. This appears to be a generated or temporary file that should not be version-controlled as part of the annotation migration.tests/Entity/Page.php (1)
10-10: LGTM! Clean migration to PHP 8 attributes.The serializer Groups import and usage have been correctly migrated from annotation to attribute namespace. The attribute syntax is properly applied to the properties.
Also applies to: 22-22, 26-26
tests/Entity/DummyCustomGroups.php (1)
9-9: LGTM! Migration is consistent.The Groups attribute is correctly applied to all properties with proper import from the Attribute namespace.
Also applies to: 16-16, 20-20, 24-24
tests/Entity/Comment.php (1)
9-9: LGTM! Attribute migration completed correctly.The serializer Groups have been consistently migrated to PHP 8 attributes across all properties.
Also applies to: 18-18, 26-26, 30-30
tests/Entity/Post.php (1)
11-11: Property migrations look good.The Groups attribute has been correctly applied to all properties with the proper import from the Attribute namespace.
Also applies to: 20-20, 24-24, 28-28, 32-32, 40-40
norkunas
force-pushed
the
drop-doctrine-annotations
branch
from
c158a81 to
ca49d9a
Compare
1 participant
Pull Request
Related issue
Fixes #<issue_number>
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Summary by CodeRabbit
Refactor
Chores
✏️ Tip: You can customize this high-level summary in your review settings.