-
Notifications
You must be signed in to change notification settings - Fork 2
add noBanner metadata for the site no to display the deweb banner #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to conditionally hide the deweb banner based on server configuration. The main purpose is to allow sites to disable the banner display through a new noBanner configuration option.
- Added
noBannerboolean field to server configuration with YAML support - Updated API model and OpenAPI specification to include the new field
- Modified client-side JavaScript to check server response before displaying banner
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/int/api/config/config.go | Added NoBanner boolean field to configuration structs and default config |
| server/int/api/handlers.go | Added NoBanner field to API response payload |
| server/int/api/resources/massaBox.html | Updated banner display logic to fetch server config and conditionally show banner |
| server/api/readAPI-V0.yml | Added noBanner boolean field to OpenAPI specification |
| server/api/read/restapi/embedded_spec.go | Updated embedded OpenAPI spec with noBanner field |
| server/api/read/models/de_web_info.go | Added NoBanner field to Go model struct |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.