MLE-25782 Refactor: Explicit naming of writeSet objects #1859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was going crazy trying to figure out if a "writeSet" was a BatchWriteSet or DocumentWriteSet. Now using more explicit names.
rjrudin
requested review from
BillFarber,
anu3990 and
stevebio
as code owners
There was a problem hiding this comment.
Pull request overview
This PR improves code clarity by renaming variables and methods from the ambiguous "writeSet" to more explicit names that distinguish between BatchWriteSet and DocumentWriteSet objects.
- Renamed the
writeSetfield inBatchWritertobatchWriteSetand its getter fromgetWriteSet()togetBatchWriteSet() - Renamed the
writeSetfield inBatchWriteSettodocumentWriteSetand its getter fromgetWriteSet()togetDocumentWriteSet() - Updated all call sites across
WriteBatcherImplto use the new method names
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WriteBatcherImpl.java | Updated all calls from getWriteSet() to getDocumentWriteSet() and from getWriteSet() getter to getBatchWriteSet() |
| BatchWriter.java | Renamed field from writeSet to batchWriteSet and updated getter method name accordingly |
| BatchWriteSet.java | Renamed field from writeSet to documentWriteSet, updated getter method name, and added class-level documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
BillFarber
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was going crazy trying to figure out if a "writeSet" was a BatchWriteSet or DocumentWriteSet. Now using more explicit names.