Live search preview #51
Open
+168
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can replace `set_` APIs to make the APIs on Pager cleaner. It makes the next change skip adding the `set_` API.
Make it possible to scroll_to a line without centering it. This will be used by the next change.
Similar to the hlsearch feature from vim, show search results as user types. This can be turned off via a config.
If the matched line is already in the current view, do not center it. This reduces scrolling in search live preview. It seems to be a general good default so I didn't add a config option.
This resolves some rendering issues where the search and prompt bar does not get re-rendered properly. Repro steps: 1. sp src/screen.rs. 2. Search for 'crate'. 'crate' gets highlighted. 3. Search for 'foo' (no result). Keep the prompt. 4. Ctrl+W. Prompt does not erase the 'foo'. Search status shows 'foo' instead of expecte 'crate'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview search as user types. Similar to vim's
hlsearch. This seems especially useful when using complex regexps.