Skip to content

fix: flush on preparation for shutdown #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GabrielePicco merged 2 commits into from
Dec 19, 2025
+3 −1
Merged

fix: flush on preparation for shutdown #753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f2aead
fix: flush on preparation for shutdown
taco-paco Dec 18, 2025
38192b4
fix: lint
taco-paco Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions magicblock-api/src/magic_validator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,6 +700,9 @@ impl MagicValidator {
self.ledger_truncator.stop();
// Calls & awaits until manual compaction is canceled
self.ledger.cancel_manual_compactions();
if let Err(err) = self.ledger.flush() {
error!("Failed to flush during shutdown preparation: {:?}", err);
}
}
}

Expand Down
1 change: 0 additions & 1 deletion magicblock-ledger/src/store/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,7 +1270,6 @@ impl Ledger {
measure: Measure::start("Ledger shutdown"),
_timer: start_ledger_shutdown_timer(),
};
self.flush()?;
self.db.backend.db.cancel_all_background_work(wait);

Ok(())
Expand Down