Skip to content

wip: checking compilation without libclang #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taco-paco wants to merge 2 commits into
base: master
Choose a base branch
from
Open

wip: checking compilation without libclang #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b95cc7c
wip: checking compilation without libclang
taco-paco Dec 17, 2025
a63298b
fix: add back lz4 support
taco-paco Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/actions/setup-build-env/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,7 @@ runs:
- name: Install system deps (libudev, LLVM/Clang)
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Update step name to reflect actual packages installed.

The step name mentions "LLVM/Clang" but libclang-dev is no longer being installed. Update the name to match the actual behavior.

Apply this diff to fix the inconsistency:

-  - name: Install system deps (libudev, LLVM/Clang)
+  - name: Install system deps (libudev)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Install system deps (libudev, LLVM/Clang)
- name: Install system deps (libudev)
🤖 Prompt for AI Agents 
.github/actions/setup-build-env/action.yml around line 30: the step name
currently reads "Install system deps (libudev, LLVM/Clang)" but
libclang-dev/LLVM/Clang are no longer installed; update the step name to
accurately list the packages actually installed (for example "Install system
deps (libudev)" or "Install system deps (libudev, libxyz)" if there are other
packages) so the action name matches behavior; edit the name string on line 30
to the corrected concise description.

if: runner.os == 'Linux'
shell: "bash"
run: |
sudo apt-get update
sudo apt-get install -y \
libudev-dev \
libclang-dev
run: sudo apt-get update && sudo apt-get install -y libudev-dev

- uses: Swatinem/rust-cache@v2
with:
Expand Down
3 changes: 1 addition & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,7 @@ features = ["dev-context-only-utils"]
# Avoid the vendored bzip2 within rocksdb-sys that can cause linker conflicts
# when also using the bzip2 crate
version = "0.22.0"
# default-features = false
# features = ["lz4"]
features = ["lz4"]
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Disable default features alongside the lz4 feature to avoid libclang dependency.

To enable only LZ4 compression: default-features = false features = ["lz4"]. By default, the bindgen-runtime feature enables the runtime feature of bindgen, which dynamically links to libclang and is suitable for most platforms and enabled by default. Since the PR objective is compilation without libclang, add default-features = false to the rocksdb dependency alongside the features = ["lz4"] specification.

🤖 Prompt for AI Agents 
In Cargo.toml around line 213, the rocksdb dependency currently enables lz4 via
features = ["lz4"] but still pulls in bindgen-runtime/libclang; update the
rocksdb dependency to disable default features by adding default-features =
false alongside features = ["lz4"] so it compiles without libclang (i.e., set
default-features = false and keep features = ["lz4"] for the rocksdb entry).


[patch.crates-io]
# some solana dependencies have solana-storage-proto as dependency
Expand Down
73 changes: 37 additions & 36 deletions test-integration/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.