Skip to content

update vllm_worker.py #3330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jbding wants to merge 4 commits into
base: main
Choose a base branch
from
Open

update vllm_worker.py #3330

jbding wants to merge 4 commits into from
+109 −99

Conversation

@jbding
Copy link

@jbding jbding commented May 13, 2024

Why are these changes needed?

  • The vllm_worker code does not catch exceptions: when I check vllm's SamplingParams function, there is parameter verification and the error ValueError is thrown out.
  • Because there is no capture, the semaphore is not released after the code execution fails, causing the model to fail to work.

Related issue number (if applicable)

Fix #3328

Checks

  • [ ✓] I've run format.sh to lint the changes in this PR.
  • [ ✗] I've included any doc changes needed.
  • [ ✓] I've made sure the relevant tests are passing (if applicable).

jbding
jbding commented Jul 29, 2024
View reviewed changes
Copy link
Author

@jbding jbding left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you have a moment. Could you please take a look at this PR? @merrymercy @vikrantrathore @yejunjin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Vllm worker does not release semaphore

2 participants

@jbding @dingjbAsia