-
Notifications
You must be signed in to change notification settings - Fork 15.4k
[NFC] [FlowSensitive] Fix missing namespace in MockHeaders #170954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFC] [FlowSensitive] Fix missing namespace in MockHeaders #170954
Conversation
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7
|
@llvm/pr-subscribers-clang Author: Florian Mayer (fmayer) ChangesThis happened to work because we were missing both a namespace close and Full diff: https://github.com/llvm/llvm-project/pull/170954.diff 1 Files Affected:
diff --git a/clang/unittests/Analysis/FlowSensitive/MockHeaders.cpp b/clang/unittests/Analysis/FlowSensitive/MockHeaders.cpp
index 76c7310e16a4f..8ea2015da08df 100644
--- a/clang/unittests/Analysis/FlowSensitive/MockHeaders.cpp
+++ b/clang/unittests/Analysis/FlowSensitive/MockHeaders.cpp
@@ -1358,6 +1358,8 @@ bool operator!=(const Status &lhs, const Status &rhs);
Status OkStatus();
Status InvalidArgumentError(const char *);
+} // namespace absl
+
#endif // STATUS_H
)cc";
@@ -1370,6 +1372,8 @@ constexpr const char StatusOrDefsHeader[] = R"cc(
#include "std_type_traits.h"
#include "std_utility.h"
+namespace absl {
+
template <typename T> struct StatusOr;
namespace internal_statusor {
|
jvoung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7 [skip ci]
This happened to work because we were missing both a namespace close and open and things happened to be included in the correct order.
This happened to work because we were missing both a namespace close and
open and things happened to be included in the correct order.