chore: updates datasources to report recoverability in errors #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanderson-ld
changed the title
tanderson-ld
commented
Dec 18, 2025
| { | ||
| // if client is initializing, make it stop waiting | ||
| _initTask.SetResult(true); | ||
| _initTask.SetResult(false); |
Contributor
Author
There was a problem hiding this comment.
'Twas the night before bugmas
tanderson-ld
commented
Dec 18, 2025
| if (newError != null && !newError.Value.Recoverable) | ||
| { | ||
| _actionable.BlacklistCurrent(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Now if a datasource decides to shutdown for a recoverable reason (who knows what that will be in the future), we don't blacklist too agressively.
kinyoklion
reviewed
Dec 18, 2025
| { | ||
| _canceller?.Cancel(); | ||
| _featureRequestor.Dispose(); | ||
| _dataSourceUpdates.UpdateStatus(DataSourceState.Off, errorInfo); |
Member
There was a problem hiding this comment.
Emits events during dispose feels like something we shouldn't be doing. Because the thing we are emitting to could already be disposed/finalized.
kinyoklion
approved these changes
Dec 18, 2025
Member
kinyoklion
left a comment
kinyoklion
left a comment
There was a problem hiding this comment.
I would prefer no data source updates triggered by dispose. But everything else looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Didn't do yet, going to do as part of overall benchtesting before release.
Adds tracking of Recover-ability on data source ErrorInfo so that can be communicated outward by datasources. Then the FDv2 datasource can blacklist conditionally on the recover-ability of the error. This now allows data sources to report Off (intentional shutdown) without getting blacklisted.
Note
Adds
RecoverabletoDataSourceStatus.ErrorInfoand updates polling/streaming (incl. FDv2) to set Interrupted vs Off, centralize shutdown, and conditionally blacklist based on recoverability, with comprehensive test updates.ErrorInfo.RecoverabletoDataSourceStatusto denote retryable vs terminal errors.ErrorInfo.FromException(Exception, bool)andFromHttpError(int, bool).HttpErrors.IsRecoverableto setRecoverable; mark JSON/store errors as recoverable.DataSourceState.Interrupted; unrecoverable toOffand complete init task withfalse.Shutdown(ErrorInfo?)helpers; ensureDispose/shutdown updates status toOff.FDv1Fallbackwhen present.Off, blacklist current source only ifnewError.Recoverable == false.FromHttpErrorsignature and assertRecoverablesemantics across HTTP 401/403 vs 5xx/network/invalid-data/store.Offand FDv1 fallback flag propagation.Written by Cursor Bugbot for commit 06e57f1. This will update automatically on new commits. Configure here.