Skip to content

Conversation

@stefonarch
Copy link
Contributor

No description provided.

src/mouse.ui Outdated
<item>
<property name="text">
<string>lrm</string>
<string>left-right-middle</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that it would be good to change to left-right-middle, etc

However, shouldn't the change be made here:

maps.append(QSharedPointer<Pair>(new Pair("lrm", tr("lrm"))));

...so that the right value is still set in the rc.xml file

Do we even need to specify these two items in the ui file. Have tried remove and it seems to work well without.

diff --git a/src/mouse.ui b/src/mouse.ui
index dd378e1..0386123 100644
--- a/src/mouse.ui
+++ b/src/mouse.ui
@@ -163,18 +163,7 @@
     </widget>
    </item>
    <item row="8" column="1" colspan="4" alignment="Qt::AlignmentFlag::AlignLeft">
-    <widget class="QComboBox" name="tapButtonMap">
-     <item>
-      <property name="text">
-       <string>lrm</string>
-      </property>
-     </item>
-     <item>
-      <property name="text">
-       <string>lmr</string>
-      </property>
-     </item>
-    </widget>
+     <widget class="QComboBox" name="tapButtonMap"/>
    </item>
    <item row="9" column="0" alignment="Qt::AlignmentFlag::AlignLeft">
     <widget class="QLabel" name="label_tapAndDrag">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was tired when I pushed this, came to my mind afterwards.
I didn't try without them in the ui file, if itworks we can remove all 4 pairs, will test that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks working, as it also is for the "theme" combos. So also the doubled translations will be removed when updating the *.ts files.

Copy link
Member

@johanmalm johanmalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants