Fix golangci-lint and remove obsolete Go-version-based alternatives #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
cncf-cla: yes
Member
Author
|
/cc @dims |
Member
Author
|
/retest |
skitt
force-pushed
the
cleanup-post-go-1.23
branch
8 times, most recently
from
da6e8e4 to
09c787b
Compare
This is required to support Go 1.23. Instead of manually running the appropriate container, which now fails, use the golangci-lint action. golint is now disabled, and causes an error if enabled. It’s supposed to be replaced by revive but the latter finds several issues that need fixing; for now, remove golint, we’ll address revive later. Signed-off-by: Stephen Kitt <skitt@redhat.com>
Since utils requires Go 1.23, code specifically for older versions is no longer necessary. Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
force-pushed
the
cleanup-post-go-1.23
branch
from
09c787b to
66458b5
Compare
skitt
changed the title
Member
|
/approve |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, skitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Since utils requires Go 1.23, code specifically for older versions is no longer necessary.
golangci-lint needs bumping to 1.60.1 (or later) to support Go 1.23. This drops support for golint; that’s supposed to be replaced by revive, but switching to the latter would require fixing several issues. For the time being, this disables golint without replacing it.
This also switches to the golangci-lint action, the previous container approach was failing with 1.60.1.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: