Add fixed-size circular buffer with io.Writer support #337
+377
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
cncf-cla: yes
Member
Author
|
/assign @liggitt |
dims
commented
Dec 17, 2025
dims
commented
Dec 17, 2025
skitt
reviewed
Dec 18, 2025
dims
force-pushed
the
add-ring-fixed
branch
3 times, most recently
from
6adfe88 to
57c85b6
Compare
dims
commented
Dec 18, 2025
skitt
reviewed
Dec 18, 2025
Introduces TypedRingFixed[T], a generic circular buffer with fixed capacity. When full, new writes overwrite the oldest entries, retaining only the most recent N elements. Useful for capturing the tail of command output or log streams where memory must remain bounded. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
changed the title
Member
|
/lgtm Thanks! |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, skitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces TypedRingFixed[T], a generic circular buffer with fixed capacity. When full, new writes overwrite the oldest entries, retaining only the most recent N elements. Useful for capturing the tail of command output or log streams where memory must remain bounded.
We need this to replace https://github.com/armon/circbuf used in k/k repo.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: