-
Notifications
You must be signed in to change notification settings - Fork 463
✨ Add support for k8s:enum tag. #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lalitc375 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @lalitc375. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Holding this PR, until we gets approval on DV. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
This PR introduces support for a +k8s:enum marker to automatically generate enum validation for Custom Resource Definitions (CRDs). This tag is used by native types to validate enums using declarative Validations.
This change simplifies the process of defining enums in CRDs. Previously, developers had to manually specify all enum values using the +kubebuilder:validation:Enum marker for every field of an enum type. This was repetitive and prone to errors, especially when enum values changed.
With this new +k8s:enum type-level marker, controller-gen automatically discovers all constant values associated with a string-based enum type and generates the corresponding validation in the OpenAPI schema. This makes the process more maintainable and less error-prone.