🐛 Fix fake client Apply with Unstructured ApplyConfiguration and resourceVersion unset #3403
+64
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
sbueringer
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
sbueringer
force-pushed
the
pr-fix-fake-client-ssa
branch
from
48b955d to
174863b
Compare
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
resourceVersion unset Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-fix-fake-client-ssa
branch
from
174863b to
7fb375a
Compare
Member
Author
|
/assign @fabriziopandini |
Member
fabriziopandini
left a comment
fabriziopandini
left a comment
There was a problem hiding this comment.
Changes looks good to me
Thanks for the extensive code coverage
/lgtm
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 3e31c1eccbdf1d81dca9742e53aa4a3df43f0684 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fake client has a bug that if Apply is used with Unstructured and without setting resourceVersion it returns the following conflict error:
This PR fixes it by treating Apply the same way as Patch
Signed-off-by: Stefan Büringer buringerst@vmware.com