Pass external callchain entry to get_perf_callchain #6515
+126
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: ec439c3 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
855781f to
2b47d31
Compare
Author
|
Upstream branch: ec439c3 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
8c70ecc to
9fa98b5
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
2b47d31 to
abf45ae
Compare
Author
|
Upstream branch: 3d60306 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
9fa98b5 to
1f21fb3
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
abf45ae to
74af854
Compare
Author
|
Upstream branch: d2749ae |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
1f21fb3 to
206639e
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
74af854 to
5cc3146
Compare
Author
|
Upstream branch: f785a31 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
206639e to
e2ddf0b
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
5cc3146 to
1d08ab8
Compare
Author
|
Upstream branch: 042d4c0 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
e2ddf0b to
983188f
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
1d08ab8 to
c428576
Compare
Author
|
Upstream branch: ac1c5bc |
added 2 commits
December 22, 2025 22:31
From BPF stack map, we want to ensure that the callchain buffer will not be overwritten by other preemptive tasks. Peter suggested provide more flexible stack-sampling APIs, which can be used in BPF, and we can still use the perf callchain entry with the help of these APIs. The next patch will modify the BPF part. In the future, these APIs will also make it convenient for us to add stack-sampling kfuncs in the eBPF subsystem, just as Andrii and Alexei discussed earlier. Signed-off-by: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Tao Chen <chen.dylane@linux.dev>
As Alexei noted, get_perf_callchain() return values may be reused if a task is preempted after the BPF program enters migrate disable mode. The perf_callchain_entres has a small stack of entries, and we can reuse it as follows: 1. get the perf callchain entry 2. BPF use... 3. put the perf callchain entry And Peter suggested that get_recursion_context used with preemption disabled, so we should disable preemption at BPF side. Acked-by: Yonghong Song <yonghong.song@linux.dev> Signed-off-by: Tao Chen <chen.dylane@linux.dev>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1034091=>bpf-next
branch
from
983188f to
71b789d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Pass external callchain entry to get_perf_callchain
version: 7
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1034091