Use correct destructor kfunc types #6426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 688b745 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
8c83cb5 to
f015201
Compare
Author
|
Upstream branch: 19f4091 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1028057=>bpf-next
branch
from
8c8508c to
7e54e3f
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
f015201 to
884c5bc
Compare
Author
|
Upstream branch: bd5bdd2 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1028057=>bpf-next
branch
from
7e54e3f to
1f589f6
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
884c5bc to
4355736
Compare
Author
|
Upstream branch: 34235a3 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1028057=>bpf-next
branch
from
1f589f6 to
e78798f
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4355736 to
5bece43
Compare
Author
|
Upstream branch: c1af446 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1028057=>bpf-next
branch
from
e78798f to
f9162b5
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
5bece43 to
52f5a27
Compare
Author
|
Upstream branch: ff34657 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1028057=>bpf-next
branch
from
f9162b5 to
739b773
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
52f5a27 to
037d2fc
Compare
Author
|
Upstream branch: ff34657 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1028057=>bpf-next
branch
from
739b773 to
1bc7fe2
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
037d2fc to
8f722b4
Compare
Author
|
Upstream branch: 8f7aa3d |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1028057=>bpf-next
branch
from
1bc7fe2 to
4b98528
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
8f722b4 to
03e2ed2
Compare
Author
|
Upstream branch: 835a507 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1028057=>bpf-next
branch
from
4b98528 to
f67ae56
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
03e2ed2 to
3ea267d
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
3ea267d to
6d4eb64
Compare
Author
|
Upstream branch: 835a507 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1028057=>bpf-next
branch
from
283b3f8 to
93314fa
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
6d4eb64 to
af4bac7
Compare
Author
|
Upstream branch: 81f88f6 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1028057=>bpf-next
branch
from
93314fa to
eed7e94
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
af4bac7 to
6ba2fc1
Compare
Author
|
Upstream branch: 5d9fb42 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1028057=>bpf-next
branch
from
eed7e94 to
3fc7fa6
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
6ba2fc1 to
362a95a
Compare
Author
|
Upstream branch: 5d9fb42 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1028057=>bpf-next
branch
from
3fc7fa6 to
23ee967
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
362a95a to
9671fbe
Compare
Author
|
Upstream branch: c93c124 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1028057=>bpf-next
branch
from
23ee967 to
a92cb82
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
9671fbe to
dad8a9c
Compare
With CONFIG_CFI enabled, the kernel strictly enforces that indirect
function calls use a function pointer type that matches the target
function. I ran into the following type mismatch when running BPF
self-tests:
CFI failure at bpf_obj_free_fields+0x190/0x238 (target:
bpf_crypto_ctx_release+0x0/0x94; expected type: 0xa488ebfc)
Internal error: Oops - CFI: 00000000f2008228 [#1] SMP
...
As bpf_crypto_ctx_release() is also used in BPF programs and using
a void pointer as the argument would make the verifier unhappy, add
a simple stub function with the correct type and register it as the
destructor kfunc instead.
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Tested-by: Viktor Malik <vmalik@redhat.com>
With CONFIG_CFI enabled, the kernel strictly enforces that indirect function calls use a function pointer type that matches the target function. As bpf_kfree_skb() signature differs from the btf_dtor_kfunc_t pointer type used for the destructor calls in bpf_obj_free_fields(), add a stub function with the correct type to fix the type mismatch. Signed-off-by: Sami Tolvanen <samitolvanen@google.com> Acked-by: Yonghong Song <yonghong.song@linux.dev>
With CONFIG_CFI enabled, the kernel strictly enforces that indirect function calls use a function pointer type that matches the target function. As bpf_testmod_ctx_release() signature differs from the btf_dtor_kfunc_t pointer type used for the destructor calls in bpf_obj_free_fields(), add a stub function with the correct type to fix the type mismatch. Signed-off-by: Sami Tolvanen <samitolvanen@google.com> Acked-by: Yonghong Song <yonghong.song@linux.dev>
Author
|
Upstream branch: 759377d |
Ensure that registered destructor kfuncs have the same type as btf_dtor_kfunc_t to avoid a kernel panic on systems with CONFIG_CFI enabled. Signed-off-by: Sami Tolvanen <samitolvanen@google.com> Acked-by: Yonghong Song <yonghong.song@linux.dev>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1028057=>bpf-next
branch
from
a92cb82 to
a3eee66
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
5 times, most recently
from
2b47d31 to
abf45ae
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
2 times, most recently
from
74af854 to
5cc3146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Use correct destructor kfunc types
version: 4
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1028057