-
Notifications
You must be signed in to change notification settings - Fork 55
feat: service registration with granular iface/ip conditions #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: service registration with granular iface/ip conditions #398
Conversation
96b1894 to
d644413
Compare
d644413 to
ed60f93
Compare
|
Thanks for your PR! At the high level I'm open to add such granular conditions. Please feel free to move it out of draft. I've a couple of comments inline. |
eba02d8 to
82094da
Compare
|
pr is out of draft |
keepsimple1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me! A few minor comments inline.
1da0ab6 to
5b9f279
Compare
5b9f279 to
2c073df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible (and ready), could you also add integration test for the new public APIs?
aae2c07 to
582e794
Compare
a32b7eb to
07a9bc7
Compare
c58a90c to
0c1e27e
Compare
0c1e27e to
c2986db
Compare
added. FYI I noticed that the tests don't run on the ubuntu build. the workflow file has but we're running on ubuntu 22.04 |
You can update the workflow to use ubuntu 22.04. |
f9046b9 to
6155275
Compare
getting test failures on 22.04: test_disable_interface_cache. tested on mainline and still failing (admittedly I tested on 24.04 not 22.04) so it seems unrelated. ok if we leave this as a follow-up? |
FWIW, on my setup looks like it's failing because, in the test, we disabled only the ipv4 interface address however, the iface returns an ipv6 address as well which does not get disabled. here we send out a query to both ipv6 and ipv4 if the |
keepsimple1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only minor comments inline. Thanks for the update!
Yes, sounds good. |
|
One more minor comment: could you mention the issue number that triggered this PR in the Description section? such that GitHub will automatically link this PR to that issue. |
done |
keepsimple1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
suggested update to mdns-sd to support granular service registration.
We would find it very useful to be able to register services with specific conditions:
@keepsimple1 if this looks like a reasonable update to you, I can finish up the pr (cleanup, tests, etc.) and take it out of draft
issue: #399