Skip to content

Conversation

@twizansk
Copy link
Contributor

@twizansk twizansk commented Oct 27, 2025

suggested update to mdns-sd to support granular service registration.

We would find it very useful to be able to register services with specific conditions:

  • associate them with with specific interfaces.
  • return only link-local ips

@keepsimple1 if this looks like a reasonable update to you, I can finish up the pr (cleanup, tests, etc.) and take it out of draft

issue: #399

@twizansk twizansk force-pushed the twizansk/granular-registration branch 6 times, most recently from 96b1894 to d644413 Compare October 27, 2025 23:19
@twizansk twizansk force-pushed the twizansk/granular-registration branch from d644413 to ed60f93 Compare October 27, 2025 23:25
@keepsimple1
Copy link
Owner

Thanks for your PR! At the high level I'm open to add such granular conditions. Please feel free to move it out of draft. I've a couple of comments inline.

@twizansk twizansk force-pushed the twizansk/granular-registration branch from eba02d8 to 82094da Compare October 28, 2025 17:56
@twizansk twizansk marked this pull request as ready for review October 28, 2025 17:59
@twizansk
Copy link
Contributor Author

pr is out of draft

Copy link
Owner

@keepsimple1 keepsimple1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me! A few minor comments inline.

@twizansk twizansk force-pushed the twizansk/granular-registration branch from 1da0ab6 to 5b9f279 Compare October 31, 2025 00:17
@twizansk twizansk force-pushed the twizansk/granular-registration branch from 5b9f279 to 2c073df Compare October 31, 2025 00:23
Copy link
Owner

@keepsimple1 keepsimple1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible (and ready), could you also add integration test for the new public APIs?

@twizansk twizansk force-pushed the twizansk/granular-registration branch 5 times, most recently from aae2c07 to 582e794 Compare October 31, 2025 22:22
@twizansk twizansk force-pushed the twizansk/granular-registration branch 2 times, most recently from a32b7eb to 07a9bc7 Compare October 31, 2025 23:08
@twizansk twizansk force-pushed the twizansk/granular-registration branch 5 times, most recently from c58a90c to 0c1e27e Compare October 31, 2025 23:32
@twizansk twizansk force-pushed the twizansk/granular-registration branch from 0c1e27e to c2986db Compare October 31, 2025 23:36
@twizansk
Copy link
Contributor Author

If possible (and ready), could you also add integration test for the new public APIs?

added. FYI I noticed that the tests don't run on the ubuntu build. the workflow file has

- name: Run tests with debugs
   if: matrix.os == 'ubuntu-20.04' || matrix.os == 'macos-14'

but we're running on ubuntu 22.04

@keepsimple1
Copy link
Owner

but we're running on ubuntu 22.04

You can update the workflow to use ubuntu 22.04.

@twizansk twizansk force-pushed the twizansk/granular-registration branch from f9046b9 to 6155275 Compare November 3, 2025 18:11
@twizansk
Copy link
Contributor Author

twizansk commented Nov 3, 2025

but we're running on ubuntu 22.04

You can update the workflow to use ubuntu 22.04.

getting test failures on 22.04: test_disable_interface_cache. tested on mainline and still failing (admittedly I tested on 24.04 not 22.04) so it seems unrelated. ok if we leave this as a follow-up?

@twizansk
Copy link
Contributor Author

twizansk commented Nov 3, 2025

but we're running on ubuntu 22.04

You can update the workflow to use ubuntu 22.04.

getting test failures on 22.04: test_disable_interface_cache. tested on mainline and still failing (admittedly I tested on 24.04 not 22.04) so it seems unrelated. ok if we leave this as a follow-up?

FWIW, on my setup looks like it's failing because, in the test, we disabled only the ipv4 interface address

however, the iface returns an ipv6 address as well which does not get disabled.

here we send out a query to both ipv6 and ipv4 if the MyIntf instance still exists

Copy link
Owner

@keepsimple1 keepsimple1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only minor comments inline. Thanks for the update!

@keepsimple1
Copy link
Owner

ok if we leave this as a follow-up?

Yes, sounds good.

@keepsimple1
Copy link
Owner

One more minor comment: could you mention the issue number that triggered this PR in the Description section? such that GitHub will automatically link this PR to that issue.

@twizansk
Copy link
Contributor Author

twizansk commented Nov 4, 2025

One more minor comment: could you mention the issue number that triggered this PR in the Description section? such that GitHub will automatically link this PR to that issue.

done

Copy link
Owner

@keepsimple1 keepsimple1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@keepsimple1 keepsimple1 merged commit 6752eaf into keepsimple1:main Nov 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants