Enable loopback interfaces by default #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keepsimple1
force-pushed
the
browse-debug
branch
2 times, most recently
from
4a68daf to
4b2eeab
Compare
keepsimple1
force-pushed
the
browse-debug
branch
from
4b2eeab to
9d9165d
Compare
keepsimple1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for fixing issue #392.
Based the fact that switching a network would "fix" the problem, I suspected that it's related to whether loopback interfaces are enabled. (After IP change detected, we would enable loopback interfaces, which were disabled by default).
To fix this issue, and to avoid any unknowns related to the loopback interfaces, I think it's a better trade-off to enable them by default. This is a change from existing default behavior.
!should not be used. Funny enough the Rust syntax made it no side effect for most cases.