Skip to content

Conversation

@devprojecthub
Copy link

@devprojecthub devprojecthub commented Dec 8, 2025

The site content is ...

@MattIPv4 MattIPv4 changed the title Update cnames_active.js projecthub.js.org Dec 8, 2025
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi! You need to fill out the PR description template that was provided to you when you created your PR, as we need the information it requests to process your subdomain request. If you need to reference the template again, it can be found at https://raw.githubusercontent.com/js-org/js.org/refs/heads/master/PULL_REQUEST_TEMPLATE.md -- the description of your PR must match the format in the template exactly, with you providing the information that it requests.

*/

var cnames_active = {
"Projecthub":"projecthub.js.org",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, three issues here:

  1. Subdomains should always be lowercase please, so projecthub, not Projecthub

  2. Entries should be added to this file in alphabetical order, not dumped at the top/bottom of the file

  3. A JS.org subdomain cannot target itself... that makes no sense. Please provide a valid target for the subdomain.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do i need to add same value that I have added in cname file of my repository.

Copy link
Member

@MattIPv4 MattIPv4 Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add whatever you want the subdomain to target... so if it is a GitHub repository, it should be <yourname>.github.io/<repositoryname>

The CNAME file in your repository should just contain the JS.org subdomain, so projecthub.js.org.

Copy link
Author

@devprojecthub devprojecthub Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. How to do it by vercel

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd target cname.vercel-dns.com with the // noCF flag set. Please do look at the file... there are ~3000 examples in there for you already.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New pull request called. Check this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future, you don't need to create a new PR, you can just edit your existing one.

@MattIPv4 MattIPv4 added invalid missing information This PR does not have all the requested information in the PR description labels Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid missing information This PR does not have all the requested information in the PR description

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants