-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
projecthub.js.org #10379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
projecthub.js.org #10379
Conversation
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi! You need to fill out the PR description template that was provided to you when you created your PR, as we need the information it requests to process your subdomain request. If you need to reference the template again, it can be found at https://raw.githubusercontent.com/js-org/js.org/refs/heads/master/PULL_REQUEST_TEMPLATE.md -- the description of your PR must match the format in the template exactly, with you providing the information that it requests.
| */ | ||
|
|
||
| var cnames_active = { | ||
| "Projecthub":"projecthub.js.org", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, three issues here:
-
Subdomains should always be lowercase please, so
projecthub, notProjecthub -
Entries should be added to this file in alphabetical order, not dumped at the top/bottom of the file
-
A JS.org subdomain cannot target itself... that makes no sense. Please provide a valid target for the subdomain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do i need to add same value that I have added in cname file of my repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add whatever you want the subdomain to target... so if it is a GitHub repository, it should be <yourname>.github.io/<repositoryname>
The CNAME file in your repository should just contain the JS.org subdomain, so projecthub.js.org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. How to do it by vercel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd target cname.vercel-dns.com with the // noCF flag set. Please do look at the file... there are ~3000 examples in there for you already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New pull request called. Check this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the future, you don't need to create a new PR, you can just edit your existing one.
Uh oh!
There was an error while loading. Please reload this page.