Add createSubmit to audit trail filter pattern #39
+114
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
WebPostAccessLoggerfilter pattern was missingcreateSubmit, which meant that credential creation events (and other resource creation viacreateSubmitendpoints) were not being logged to the audit trail in Splunk.Problem
When auditing Jenkins activity via Splunk, credential updates and deletions were properly logged, but credential creations were silently ignored:
configSubmitupdateSubmitdoDeletecreateSubmitThis is a security gap - there was no way to audit who created a credential from the audit trail.
Fix
Added
createSubmitto theFILTER_PATTERNregex inWebPostAccessLogger.java.Testing
WebPostAccessLoggerTest.java)privateto package-visible to allow tests to reference the actual pattern (avoiding duplication)Verification
This issue was discovered and verified on a production Jenkins controller by:
updated credentials.xmlby SYSTEM)