Fix language in section 01 01 01 #179
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
danthe1st
left a comment
danthe1st
left a comment
There was a problem hiding this comment.
Please note that I am not a maintainer and I'm not working at Oracle. I don't have any authority here. What I'm writing here are merely suggestions and what you need to change is to be decided by the maintainers.
That being said, this PR might be a good chance to also change the article to install/use JDK 25 instead of JDK 19 (As Oracle designated JDK 25 to be an LTS, that's also what people would be more likely to use I guess).
| > These two steps: compilation and execution require two specific pieces of software that are part of the Java Development Kit, also known as the JDK. You will see how to download the JDK for free and how to install it later in this tutorial. | ||
| Note that starting with Java SE 11 you can also merge these two steps into one, by executing a `.java` file directly. You can use these feature only if you are executing a program that is written in a single file. This way of executing your java application does not work if your java code spans more than one file. | ||
| Note that starting with Java SE 11 you can also merge these two steps into one, by executing a `.java` file directly. You can use these feature _only_ if you are executing a program that is written in a single file. |
There was a problem hiding this comment.
Technically that's outdated with JDK 22 (which allows running multi-file programs like that) but I am not sure about the best way to say that.
app/pages/learn/01_tutorial/01_your-first-java-app/01_getting-started-with-java.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/01_your-first-java-app/01_getting-started-with-java.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/01_your-first-java-app/01_getting-started-with-java.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/01_your-first-java-app/01_getting-started-with-java.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/01_your-first-java-app/01_getting-started-with-java.md
Show resolved
Hide resolved
| ``` | ||
|
|
||
| If you choose this option, you'll have to precede your `javac` and `java` commands with `C:\jdk19\bin\` each time you compile or run a program. To avoid this extra typing, consult the section Updating the `PATH` variable in the JDK 19 installation instructions. | ||
| If you choose this option, you'll have to precede your `javac` and `java` commands with `C:\jdk19\bin\` each time you compile or run a program. To avoid this extra typing, consult the section [Updating the `PATH` variable](<!-- NOTE: Missing hyperlink -->) in the JDK 19 installation instructions. |
There was a problem hiding this comment.
I think the <!-- NOTE: Missing hyperlink --> is here by mistake.
There was a problem hiding this comment.
That was a placeholder. I meant to put in the hyperlink to that article, but I wasn't able to find it.
There was a problem hiding this comment.
I think the change introduced in this commit should fix this.
I also removed the '19' to avoid the need to change this in the future.
| #### Error Messages on Microsoft Windows Systems | ||
| <!-- NOTE: What error? --> |
There was a problem hiding this comment.
This comment seems to be a leftover that should be addressed before merging as well.
There was a problem hiding this comment.
Further below, on line 421, there's this paragraph:
If you receive this error,
javacannot find your bytecode file,HelloWorldApp.class.
There's no previous codeblock containing the error in question.
app/pages/learn/01_tutorial/01_your-first-java-app/01_getting-started-with-java.md
Outdated
Show resolved
Hide resolved
app/pages/learn/01_tutorial/01_your-first-java-app/01_getting-started-with-java.md
Outdated
Show resolved
Hide resolved
Incorporated suggestions from review by danthe1st
Mentioned multi-file program execution-from-command-line feature introduced in JDK 22.
Inserted hyperlink to article explaining how to update PATH variable
2 participants
Redid the edits introduced in #178 (comment)
Corrected grammar and made a few more edits, including but not limited to:
TODO: Inspect for missing resources marked by
<!-- NOTE: