[SYCL][ABI-break] Simplify interop_handle constructor
#20965
+12
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accrording to spec "The interop_handle class is an abstraction over the queue which is being used to invoke the host task and its associated device and context." and currently interop_handle object is created internally at the time of submission to the queue, so queue is always supposed to be available. Device and context are the ones associated with the queue, so it seems that those arguments are redundant.
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to spec "The interop_handle class is an abstraction over the queue which is being used to invoke the host task and its associated device and context." and currently interop_handle object is created internally at the time of submission to the queue, so queue is always supposed to be available. Device and context are the ones associated with the queue, so it seems that those parameters in the constructor are redundant.