Skip to content

Conversation

@xin3he
Copy link
Contributor

@xin3he xin3he commented Dec 18, 2025

  • Remove the duplicate LLMDataloader code and use the dataloader fixture to initialize it, ensuring it is initialized only once.
  • Remove the code related to unit testing and follow the Pytest coding style.
  • Add fixtures: tiny_opt_model(three layers), opt_model(for accurcay), opt_tokenizer for easy-of-use
  • Remove the duplicate model_infer function and move to helper.py for common usage.
  • Add README to introduce how to use fixtures and helper module.
  • Replace all UTs with fixture and helper function.

Co-authors: @n1ck-guo @XuehaoSun

Signed-off-by: He, Xin3 <xin3.he@intel.com>
Signed-off-by: He, Xin3 <xin3.he@intel.com>
@xin3he xin3he marked this pull request as draft December 18, 2025 09:15
@xin3he xin3he changed the title UT refactor UT refactor for preview Dec 18, 2025
pre-commit-ci bot and others added 3 commits December 18, 2025 09:17
Signed-off-by: n1ck-guo <heng.guo@intel.com>
Signed-off-by: He, Xin3 <xin3.he@intel.com>
xin3he and others added 2 commits December 18, 2025 20:30
Signed-off-by: He, Xin3 <xin3.he@intel.com>
n1ck-guo and others added 6 commits December 18, 2025 21:35
Signed-off-by: n1ck-guo <heng.guo@intel.com>
Signed-off-by: He, Xin3 <xin3.he@intel.com>
Signed-off-by: n1ck-guo <heng.guo@intel.com>
Signed-off-by: n1ck-guo <heng.guo@intel.com>
Signed-off-by: n1ck-guo <heng.guo@intel.com>
xin3he and others added 4 commits December 21, 2025 09:18
Signed-off-by: He, Xin3 <xin3.he@intel.com>
Signed-off-by: sys-lpot-val <sys_lpot_val@intel.com>
Signed-off-by: He, Xin3 <xin3.he@intel.com>
Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>
# install AutoRound
cd ${REPO_PATH}
pip uninstall auto-round -y
uv pip install torch==2.8.0 torchvision
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to run most UTs on the latest version, while maintaining a specific environment for those that have known issues.

@xin3he
Copy link
Contributor Author

xin3he commented Dec 22, 2025

found this issue when building tiny VLM: huggingface/transformers#43005

Signed-off-by: He, Xin3 <xin3.he@intel.com>
@xin3he xin3he marked this pull request as ready for review December 22, 2025 16:16
xin3he and others added 3 commits December 23, 2025 00:16
Signed-off-by: n1ck-guo <heng.guo@intel.com>
Signed-off-by: He, Xin3 <xin3.he@intel.com>
Signed-off-by: He, Xin3 <xin3.he@intel.com>
xin3he and others added 6 commits December 23, 2025 17:01
Signed-off-by: He, Xin3 <xin3.he@intel.com>
Signed-off-by: He, Xin3 <xin3.he@intel.com>
Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>
Signed-off-by: He, Xin3 <xin3.he@intel.com>
Copy link
Contributor

@luoyu-intel luoyu-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARK test looks OK

Signed-off-by: He, Xin3 <xin3.he@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants