Skip to content

IBX-11038: Content rendering in BO fails after deleting user that created the content #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sztig wants to merge 1 commit into
base: main
Choose a base branch
from
Open

IBX-11038: Content rendering in BO fails after deleting user that created the content #1796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/Tab/LocationView/AuthorsTab.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ private function supplyLastContributor(array &$parameters, VersionInfo $versionI
private function supplyCreator(array &$parameters, ContentInfo $contentInfo): void
{
$parameters['creator'] = null;
$ownerId = $contentInfo->getOwner()->getUserId();
$ownerId = $contentInfo->ownerId;
Copy link
Contributor

@konradoboza konradoboza Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you figure out why is it different than getOwner()->getUserId()? We avoid magic whenever possible and that was also the intention behind this change. //POV ping @alongosz.

Copy link
Contributor Author

@Sztig Sztig Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I didn't dig too deep, just saw we have used $contentInfo->ownerId and we don't have a getter for the ownerId either so I have just reverted to this.

Copy link
Contributor

@konradoboza konradoboza Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This supposed to be an equivalent, that's why I ask. I will let Andrew give his cents though.


if ((new UserExists($this->userService))->isSatisfiedBy($ownerId)) {
$parameters['creator'] = $this->userService->loadUser($ownerId);
Expand Down
2 changes: 1 addition & 1 deletion src/lib/UI/Value/Content/VersionInfo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/
class VersionInfo extends CoreVersionInfo
{
protected User $author;
protected ?User $author;

/** @var \Ibexa\Contracts\Core\Repository\Values\Content\Language[] */
protected array $translations;
Expand Down
Loading