-
-
Notifications
You must be signed in to change notification settings - Fork 185
Implement protobuf #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gnzsnz
wants to merge
13
commits into
ib-api-reloaded:main
Choose a base branch
from
gnzsnz:protobuf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement protobuf #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
works with protobuf ONLY, requires 10.40 or greater
Contributor
Author
|
Still a long way to go, but I wanted to share a version that can connect, sync account related objects and perform some basic requests and disconnect. Implementation status, with their
|
- Added logging for ticker data reception and processing. - Introduced new methods in Ticker class for handling various tick data types (price, size, string, generic, computation). - Updated Wrapper class to emit events for tick data using a bus system. - Removed redundant tick type mappings and replaced them with more structured handling. - Enhanced error handling for malformed tick data. - Improved readability and maintainability of the code by organizing tick data processing logic.
Contributor
Author
|
added ticker protobuf support |
- Introduced IneligibilityReason dataclass for better data structure. - Updated ContractDetails to use a list of IneligibilityReason. - historical schedule. - Improved market data converters to handle edge cases. - Cleaned up unused imports and methods across various modules.
- BiDict class to encapsulate wrapper state management - reactive bus implemented: ticker_bus, response_bus, subscription_bus - object logic encapsulated on the object itself, rather than in Wrapper class - all subscriptions are implemented. realtimeBar, , keepUpToDate, scanners, PnL and PnLSingle - placeOrder,cancelOrder, whatIfOrder - Ticker and tickByTick - Implement tests for subscription converters including ScannerParametersRequest, ScannerSubscriptionRequest, and PnL requests. - Add tests for trade converters covering order creation, conditions, and execution details. - Ensure comprehensive coverage for various order conditions and soft dollar tiers. - Validate the conversion of protobuf messages to domain objects and vice versa. - Most of methods are implemented, except for news related and market L2.
… improve data handling - Added new tick types for ETF NAV including close, prior close, bid, ask, last, frozen last, high, and low. - Updated Ticker dataclass to include new fields for ETF NAV data. - Modified the __post_init__ method to initialize new ETF NAV fields. - Improved the handling of ticker data updates to accommodate new tick types. - Refactored ticker data processing methods for clarity and efficiency. feat(util): Introduce quantize_decimals decorator for Decimal fields - Added a decorator to quantize Decimal fields in dataclass objects to specified decimal places. - Enhanced the parseIBDatetime function to correctly handle datetime strings. refactor(wrapper): Streamline ticker and subscription handling - Consolidated tick data handling methods to reduce redundancy. - Updated method signatures to remove unnecessary parameters. - Improved error handling for unknown request IDs in ticker delivery methods. chore(tests): Update tests for market data and trade converters - Refactored test cases to align with changes in the codebase. - Ensured tests validate new fields and behaviors introduced in the Ticker class. - Updated import paths for trade converter functions to reflect new module structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
works with protobuf ONLY, requires 10.40 or greater
replaces wrapper._results with a reactive pipeline implemented in eventkit. This simplifies the solution by removing state management
simple test script