fix: add missing Factory methods to Validator facade #297
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Validator facade proxies to ValidationFactory but was missing the Factory interface methods in its docblock. This caused PHPStan errors when using Validator::make() despite it being the documented pattern. Other facades (Cache, Mail) correctly include their Factory methods.
binaryfire
force-pushed
the
fix/validator-facade-make-method
branch
from
223aa4a to
f61246f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Validator facade proxies to
ValidationFactorybut was missing the Factory interface methods in its docblock. This caused PHPStan errors when usingValidator::make()despite it being the documented pattern.Other facades (Cache, Mail) correctly include their Factory methods.