This repository was archived by the owner on May 22, 2019. It is now read-only.
Cache fixes #5
Open
Cache fixes #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a sub-optimal solution to the stale rev_cache problem. Basically if verifyrev gets a valid SHA from an external git call that isn't in the rev_dict or tag_set, verifyrev attempt to rebuild the cache.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a reroll of the stale cache fix... It did require replacing Lock with RLock, and while I was at it I moved a lot of stuff around... There's a lot of repeated code, but I wanted to try to avoid rebuilding the cache if it didn't need to be done. Let me know what you think.
Thanks,
Stephen