-
Notifications
You must be signed in to change notification settings - Fork 19
Integrate pallet-fixed-validators-set #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
9963ac7 to
bc864c6
Compare
5fa9eb4 to
88f4b90
Compare
a3f2faa to
319084c
Compare
319084c to
a15fec9
Compare
88f4b90 to
040c810
Compare
a15fec9 to
57d1447
Compare
|
I have updated the PR description with some notes on the intent for this change. Also, I'm tempted to postpone the complete testing coverage of this feature for a less urgent moment; please give me your opinion on what it critical to test in this high-urgency timing, and what we could test later. I, for one, think we should add tests to see to it that the |
b780da5 to
cc5f24c
Compare
|
I've added the test I wanted and it turns out there is an issue there! I've decided to provide a separate PR for the fix: #1621 |
324db2b to
753c3d0
Compare
…est (#1620) Add more checks to verify slashin logic at a corresponding runtime test
* Add dedupe utils * Implement validator deduplication based on account id and the first-in order * Fix the doc comment on the DedupeKeyExtractor::Output * Fixed doc comment on DedupeIter::dedupe_key_extractor * Apply suggestion from @dmitrylavrenov Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com> * Add a test * Remove the broken impl (doesn't work either way) --------- Co-authored-by: Dmitry Lavrenov <39522748+dmitrylavrenov@users.noreply.github.com>
753c3d0 to
b4369af
Compare
This is a continuation of #1617. Here we integrate the fixed validators set with the humanode session, humanode offences, runtime, peer and etc.
Feel free to note what's needed to be done here with regard to Q/A - like more tests or benches.
The intended design: