candle: health check by queuing on cuda #775
Open
+23
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #775
Fixes a crucial health check, that when a GPU has a driver failure (fallen of the bus etc, or CUDA OOM). TEI technically is very unlikley to OOM during runtime, as it allocates only ~10-20MB more than during warmup in some edge cases. I have never seen it OOM on cuda.
However, if you have a driver issue, #775 fails. To make things worse, the way things are set up in k8s is that once one replica starts erroring at very fast rates, it might consume a lot of requests. (more than healthy replicas, making incidents worse)
On CPU , works great, compiled via
On GPU, works great, compiled via
cargo build --release --bin text-embeddings-router -F candle-cuda -F dynamic-linking -F http --no-default-featuresBefore submitting
instasnapshots?Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.