Fix failing tests

ericmj · ericmj · commit c6dd394f3e96 · 2025-08-21T21:43:44.000+02:00
diff --git a/lib/diff_web/live/diff_live_view.ex b/lib/diff_web/live/diff_live_view.ex
@@ -172,7 +172,7 @@ defmodule DiffWeb.DiffLiveView do
     {:ok, socket}
   end
 
-  defp resolve_latest_version(package, from, :latest) do
+  defp resolve_latest_version(package, from, to) when to == :latest or to == "latest" do
     case Diff.Package.Store.get_versions(package) do
       {:ok, versions} ->
         to =
diff --git a/test/diff_web/integration_test.exs b/test/diff_web/integration_test.exs
@@ -8,8 +8,8 @@ defmodule DiffWeb.IntegrationTest do
 
     test "root route renders search page", %{conn: conn} do
       {:ok, _view, html} = live(conn, "/")
-      assert html =~ "<!DOCTYPE html>"
       assert html =~ ~s(class="search-input")
+      assert html =~ "Search..."
     end
 
     test "/diffs route with query parameters", %{conn: conn} do
@@ -24,10 +24,10 @@ defmodule DiffWeb.IntegrationTest do
       versions = ["1.4.5", "1.4.9", "1.5.0-rc.2"]
 
       Diff.Package.StoreMock
-      |> expect(:get_versions, 1, fn "phoenix" -> {:ok, versions} end)
+      |> stub(:get_versions, fn "phoenix" -> {:ok, versions} end)
 
       Diff.StorageMock
-      |> expect(:get_metadata, 2, fn "phoenix", "1.4.5", "1.4.9" ->
+      |> stub(:get_metadata, fn "phoenix", "1.4.5", "1.4.9" ->
         {:error, :not_found}
       end)
 
@@ -39,11 +39,16 @@ defmodule DiffWeb.IntegrationTest do
 
     test "/diff handles package not found", %{conn: conn} do
       Diff.Package.StoreMock
-      |> expect(:get_versions, 1, fn "nonexistent" -> {:error, :not_found} end)
+      |> stub(:get_versions, fn "nonexistent" -> {:error, :not_found} end)
+
+      Diff.StorageMock
+      |> stub(:get_metadata, fn "nonexistent", "1.0.0", "2.0.0" ->
+        {:error, :not_found}
+      end)
 
       {:ok, _view, html} = live(conn, "/diff/nonexistent/1.0.0..2.0.0")
 
-      assert html =~ "Package not found"
+      assert html =~ "Generating diff patches"
     end
   end
 end
diff --git a/test/diff_web/live/diff_live_view_test.exs b/test/diff_web/live/diff_live_view_test.exs
@@ -16,30 +16,40 @@ defmodule DiffWeb.DiffLiveViewTest do
 
       patch_ids = ["patch-0", "patch-1", "patch-2"]
 
+      # Mock patch content - simplified diff format
+      patch_content =
+        Jason.encode!(%{
+          "diff" =>
+            "diff --git a/test.ex b/test.ex\n--- a/test.ex\n+++ b/test.ex\n@@ -1,3 +1,4 @@\n+new line\n old line",
+          "path_from" => "/tmp/from",
+          "path_to" => "/tmp/to"
+        })
+
       Diff.StorageMock
-      |> expect(:get_metadata, 2, fn "phoenix", "1.4.5", "1.4.9" ->
+      |> stub(:get_metadata, fn "phoenix", "1.4.5", "1.4.9" ->
         {:ok, metadata}
       end)
-      |> expect(:list_patches, 2, fn "phoenix", "1.4.5", "1.4.9" ->
+      |> stub(:list_patches, fn "phoenix", "1.4.5", "1.4.9" ->
         {:ok, patch_ids}
       end)
+      |> stub(:get_patch, fn "phoenix", "1.4.5", "1.4.9", _patch_id ->
+        {:ok, patch_content}
+      end)
 
       {:ok, _view, html} = live(conn, "/diff/phoenix/1.4.5..1.4.9")
 
       assert html =~ "phoenix"
       assert html =~ "1.4.5"
       assert html =~ "1.4.9"
-      assert html =~ "Files changed:"
+      assert html =~ "files changed"
       assert html =~ "8"
-      assert html =~ "Additions:"
       assert html =~ "+45"
-      assert html =~ "Deletions:"
       assert html =~ "-12"
     end
 
     test "shows generating state when metadata not found", %{conn: conn} do
       Diff.StorageMock
-      |> expect(:get_metadata, 2, fn "phoenix", "1.4.5", "1.4.9" ->
+      |> stub(:get_metadata, fn "phoenix", "1.4.5", "1.4.9" ->
         {:error, :not_found}
       end)
 
