Remove dead code

Author: ericmj

lib/diff/storage/gcs.ex

@@ -5,43 +5,6 @@ defmodule Diff.Storage.GCS do
 
   @gs_xml_url "https://storage.googleapis.com"
 
-  def get(package, from_version, to_version) do
-    with {:ok, hash} <- combined_checksum(package, from_version, to_version),
-         url = url(key(package, from_version, to_version, hash)),
-         {:ok, 200, _headers, stream} <-
-           Diff.HTTP.retry("gs", fn -> Diff.HTTP.get_stream(url, headers()) end) do
-      {:ok, stream}
-    else
-      {:ok, 404, _headers, _body} ->
-        {:error, :not_found}
-
-      {:ok, status, _headers, _body} ->
-        Logger.error("Failed to get diff from storage. Status #{status}")
-        {:error, :not_found}
-
-      {:error, reason} ->
-        Logger.error("Failed to get diff from storage. Reason #{inspect(reason)}")
-        {:error, :not_found}
-    end
-  end
-
-  def put(package, from_version, to_version, stream) do
-    with {:ok, hash} <- combined_checksum(package, from_version, to_version),
-         url = url(key(package, from_version, to_version, hash)),
-         {:ok, 200, _headers, _body} <-
-           Diff.HTTP.retry("gs", fn -> Diff.HTTP.put_stream(url, headers(), stream) end) do
-      :ok
-    else
-      {:ok, status, _headers, _body} ->
-        Logger.error("Failed to put diff to storage. Status #{status}")
-        {:error, :not_found}
-
-      error ->
-        Logger.error("Failed to put diff to storage. Reason #{inspect(error)}")
-        error
-    end
-  end
-
   def get_patch(package, from_version, to_version, patch_id) do
     with {:ok, hash} <- combined_checksum(package, from_version, to_version),
          url = url(patch_key(package, from_version, to_version, hash, patch_id)),
@@ -149,10 +112,6 @@ defmodule Diff.Storage.GCS do
     end
   end
 
-  defp key(package, from_version, to_version, hash) do
-    "diffs/#{package}-#{from_version}-#{to_version}-#{hash}.html"
-  end
-
   defp patch_key(package, from_version, to_version, hash, patch_id) do
     "diffs/patches/#{package}-#{from_version}-#{to_version}-#{hash}-#{patch_id}.patch"
   end

lib/diff/storage/local.ex

@@ -3,37 +3,6 @@ defmodule Diff.Storage.Local do
 
   @behaviour Diff.Storage
 
-  def get(package, from_version, to_version) do
-    case combined_checksum(package, from_version, to_version) do
-      {:ok, hash} ->
-        filename = key(package, from_version, to_version, hash)
-        path = Path.join([dir(), package, filename])
-
-        if File.regular?(path) do
-          {:ok, File.stream!(path, [:read_ahead])}
-        else
-          {:error, :not_found}
-        end
-
-      {:error, :not_found} ->
-        {:error, :not_found}
-    end
-  end
-
-  def put(package, from_version, to_version, stream) do
-    with {:ok, hash} <- combined_checksum(package, from_version, to_version),
-         filename = key(package, from_version, to_version, hash),
-         path = Path.join([dir(), package, filename]),
-         :ok <- File.mkdir_p(Path.dirname(path)) do
-      Enum.into(stream, File.stream!(path, [:write_delay]))
-      :ok
-    else
-      {:error, reason} ->
-        Logger.error("Failed to store diff. Reason: #{inspect(reason)}.")
-        {:error, reason}
-    end
-  end
-
   def get_patch(package, from_version, to_version, patch_id) do
     case combined_checksum(package, from_version, to_version) do
       {:ok, hash} ->
@@ -152,10 +121,6 @@ defmodule Diff.Storage.Local do
     end
   end
 
-  defp key(package, from_version, to_version, hash) do
-    "#{package}-#{from_version}-#{to_version}-#{hash}.html"
-  end
-
   defp patch_key(package, from_version, to_version, hash, patch_id) do
     "#{package}-#{from_version}-#{to_version}-#{hash}-#{patch_id}.patch"
   end

lib/diff/storage/storage.ex

@@ -2,7 +2,6 @@ defmodule Diff.Storage do
   @type package :: String.t()
   @type from_version :: String.t()
   @type to_version :: String.t()
-  @type diff :: Enum.t()
   @type patch_id :: String.t()
   @type patch_html :: String.t()
   @type diff_metadata :: %{
@@ -12,9 +11,6 @@ defmodule Diff.Storage do
           files_changed: non_neg_integer()
         }
 
-  @callback get(package, from_version, to_version) :: {:ok, diff} | {:error, term}
-  @callback put(package, from_version, to_version, diff) :: :ok | {:error, term}
-
   # New patch-level storage callbacks
   @callback get_patch(package, from_version, to_version, patch_id) ::
               {:ok, patch_html} | {:error, term}
@@ -29,14 +25,6 @@ defmodule Diff.Storage do
 
   defp impl(), do: Application.get_env(:diff, :storage_impl)
 
-  def get(package, from_version, to_version) do
-    impl().get(package, from_version, to_version)
-  end
-
-  def put(package, from_version, to_version, diff) do
-    impl().put(package, from_version, to_version, diff)
-  end
-
   def get_patch(package, from_version, to_version, patch_id) do
     impl().get_patch(package, from_version, to_version, patch_id)
   end