Skip to content

Solved a Bug on Memo Blocks Calculation, Thanks to PabloPioli #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EmanueleBonin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solved a Bug on Memo Blocks Calculation, Thanks to PabloPioli #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dBASE.NET/DbfRecord.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,10 @@ internal void Write(BinaryWriter writer, Encoding encoding) {

Memowriter.Write(BitConverter.GetBytes((int)buffer.Length).Reverse().ToArray()); // Length of memo(in bytes) Big Endian
Memowriter.Write(buffer);
UsedBlocks = (int)Math.Ceiling(buffer.Length / (decimal)BlockSize);
// EB: Thank to pablopioli for the bug report.
// "In the memo file when you calculate the number of blocks needed you forgot to add the 8 bytes for the block header.
// If the size of the data is just a little bytes shorter than the block size you will lose those last bytes"
UsedBlocks = (int)Math.Ceiling(buffer.Length + 8 / (decimal)BlockSize);
// Fill rest of the used blocks with 0x00
for (int i = 0; i < UsedBlocks * BlockSize - buffer.Length; i++) {
Memowriter.Write((byte)0x00);
Expand Down