Move aws_local into file-store
#1111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldjeffrey
requested review from
bbalser,
connormck333,
dcyoung,
jeffgrunewald,
kurotych and
macpie
connormck333
approved these changes
Dec 19, 2025
kurotych
reviewed
Dec 19, 2025
Member
kurotych
left a comment
kurotych
left a comment
There was a problem hiding this comment.
Is it possible to make aws_local doesn't depend on file-store?
If yes, as for me, it would be better solution rather than moving it inside file_store,
because then I can use aws_local independently from file_store (not sure we have real cases for now, but still)
- Removes circular dependency on aws-local <-> file-store - provides a way for file-store to test itself going through a proper client - update mobile-verifier test
michaeldjeffrey
force-pushed
the
mj/aws-local-to-file-store
branch
from
5b107cd to
9f99cfe
Compare
bbalser
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file-storeto test itself with localstack without needing to put tests in atests/directoryfile_info_poller