-
Notifications
You must be signed in to change notification settings - Fork 35
[mobile config] track asset ownership (part 1) #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kurotych
wants to merge
21
commits into
main
Choose a base branch
from
kurotych/mobile_config/track_asset_ownership
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ee62432
Add migration: drop_mobile_radio_tracker.sql
kurotych 4799030
Merge branch 'main' into kurotych/mobile_config/track_asset_ownership
kurotych 87d80bb
Add add_owner_hash_to_gateways migration
kurotych 1e4d9ae
Update db func
kurotych 397eafd
Fix and refactor tests
kurotych 37d5e17
Merge branch 'main' into kurotych/mobile_config/track_asset_ownership
kurotych 746b95e
Use gateway builder in tests
kurotych e35bc33
Refactor updating gateways logic
kurotych 4c97859
Merge branch 'main' into kurotych/mobile_config/track_asset_ownership
kurotych 336e54c
Add owner_chagned_at field
kurotych 2b843fa
Track owner changing correctly
kurotych 24ee7e3
Delete mobile_config cli import
kurotych 1d88a37
Track owner
kurotych c92432a
Merge branch 'main' into kurotych/mobile_config/track_asset_ownership
kurotych 7f8cdb1
Backfill owners
kurotych 62a88fc
Add test_gateway_tracker_owner_tracking
kurotych 5475cf2
Make sure new record was created
kurotych c9ec56f
Don't updated (yet) last_changed_at if owner was changed
kurotych 147a132
Add backfill owner test
kurotych e8d76d3
Fix fmt
kurotych e12e063
Rename migration file
kurotych File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
mobile_config/migrations/20251209173943_drop_mobile_radio_tracker.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| DROP TABLE IF EXISTS mobile_radio_tracker; |
3 changes: 3 additions & 0 deletions
3
mobile_config/migrations/20251215132218_add_owner_to_gateways.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ALTER TABLE gateways | ||
| ADD COLUMN IF NOT EXISTS owner VARCHAR(255), | ||
| ADD COLUMN IF NOT EXISTS owner_changed_at TIMESTAMPTZ; | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration file name includes "hash" (add_owner_hash_to_gateways) but the migration only adds owner and owner_changed_at columns, not anything hash-related. The file name should be updated to accurately reflect what the migration does, such as "add_owner_to_gateways.sql".