Skip to content

H-5884: Add Panel SubView, with Horizontal and Vertical SubViews containers #8209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
kube wants to merge 5 commits into
base: cf/h-5883-extract-styles-from-all-components
Choose a base branch
from
Draft

H-5884: Add Panel SubView, with Horizontal and Vertical SubViews containers #8209

kube wants to merge 5 commits into from

Conversation

@kube
Copy link
Collaborator

@kube kube commented Dec 22, 2025

🌟 What is the purpose of this PR?

🔗 Related links

  • ...

🚫 Blocked by

  • ...

🔍 What does this change?

  • ...

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing
  • modifies an npm-publishable library and I have added a changeset file(s)
  • modifies a Cargo-publishable library and I have amended the version
  • modifies a Cargo-publishable library, but it is not yet ready to publish
  • modifies a block that will need publishing via GitHub action once merged
  • I am unsure / need advice

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change
  • are in a state where docs changes are not yet required but will be
  • require changes to docs which are made as part of this PR
  • require changes to docs which are not made in this PR
    • Provide more detail here
  • I am unsure / need advice

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph
  • affected the execution graph, and the turbo.json's have been updated to reflect this
  • I am unsure / need advice

⚠️ Known issues

🐾 Next steps

🛡 What tests cover this?

❓ How to test this?

  1. Checkout the branch / view the deployment
  2. Try X
  3. Confirm that Y

📹 Demo

@github-actions github-actions bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team labels Dec 22, 2025
This was referenced Dec 22, 2025
Merged
Merged
Open
@kube Graphite App
Copy link
Collaborator Author

kube commented Dec 22, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kube kube mentioned this pull request Dec 22, 2025
Open
15 tasks
@kube kube force-pushed the cf/h-5884-create-panelview-component branch from dea993b to 303e1ef Compare December 22, 2025 23:13
@kube kube force-pushed the cf/h-5883-extract-styles-from-all-components branch from 4ddbfe3 to 86618ff Compare December 22, 2025 23:13
@kube kube mentioned this pull request Dec 22, 2025
Draft
15 tasks
@kube kube changed the title Add Panel SubView, with Horizontal and Vertical SubViews containers H-5884: Add Panel SubView, with Horizontal and Vertical SubViews containers Dec 22, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 23, 2025
View reviewed changes
libs/@hashintel/petrinaut/src/components/sub-view/vertical-sub-views-container.tsx
document.addEventListener("mousemove", handleResizeMove);
document.addEventListener("mouseup", handleResizeEnd);
document.body.style.cursor = "ns-resize";
document.body.style.userSelect = "none";

Check warning

Code scanning / Semgrep PRO

Semgrep Finding: ajinabraham.njsscan.generic.hardcoded_secrets.node_username Warning

A hardcoded username in plain text is identified. Store it properly in an environment variable.
@kube kube force-pushed the cf/h-5884-create-panelview-component branch from 5c96f80 to 1043468 Compare December 23, 2025 14:51
@kube kube force-pushed the cf/h-5883-extract-styles-from-all-components branch from 86618ff to 5e05299 Compare December 23, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kube kube

Labels

area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kube